MAJOR: --replay records the wrong winner + auction and revocation coverage gaps #125

New issue

Closed

opened 2026-10-01 15:31:08 +00:00 by Winnie · 0 comments

Winnie commented

2026-10-01 15:31:08 +00:00

Owner

Found by the v0.6.0 review (issue #118). Several replay defects:

replayOutcome (replay.go:229-238) sets winner_seat/winner_name by iterating g.Banks and overwriting with EVERY alive bank, so the last alive seat wins the replay — not g.Winner (the highest-equity standing bank, game.go:1036-1043). With Survivors=3 (the default), most games end with several standing banks and the replay's winner is systematically wrong. Verified: 10 seeded games, replay winner was always the last alive seat; 3 of 10 contradicted the console FINAL RANKING.
ReplayTurn.Auction is a single slot: two bankruptcies in one financePhase silently overwrite the first auction record.
When len(bids)==0 (the last bank fails), bankrupt() returns before replayAuction — that bankruptcy is absent from the replay entirely.
Revocations are never recorded (no replay event for revokeOffers / the revoke? hook).
ReplayFill omits turns_left, so bond accruals cannot be recomputed from the file alone.

Found by the v0.6.0 review (issue #118). Several replay defects: - replayOutcome (replay.go:229-238) sets winner_seat/winner_name by iterating g.Banks and overwriting with EVERY alive bank, so the last alive seat wins the replay — not g.Winner (the highest-equity standing bank, game.go:1036-1043). With Survivors=3 (the default), most games end with several standing banks and the replay's winner is systematically wrong. Verified: 10 seeded games, replay winner was always the last alive seat; 3 of 10 contradicted the console FINAL RANKING. - ReplayTurn.Auction is a single slot: two bankruptcies in one financePhase silently overwrite the first auction record. - When len(bids)==0 (the last bank fails), bankrupt() returns before replayAuction — that bankruptcy is absent from the replay entirely. - Revocations are never recorded (no replay event for revokeOffers / the revoke? hook). - ReplayFill omits turns_left, so bond accruals cannot be recomputed from the file alone.

Winnie referenced this issue

2026-10-01 15:31:23 +00:00

Massive code review before v0.6.0 #118

Winnie was assigned by robertismo

2026-10-01 15:38:42 +00:00

Winnie referenced this issue from a commit

2026-10-01 15:49:10 +00:00

replay: correct winner, per-bankruptcy auctions, revocations, fill terms (Closes #125)

Winnie referenced this issue from a pull request that will close it,

2026-10-01 15:49:33 +00:00

Replay: correct winner, per-bankruptcy auctions, revocations, fill terms (Closes #125) #134