No reviewers
Labels
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Winnie/bankwars!99
Loading…
Reference in a new issue
No description provided.
Delete branch "98-tfix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Ruled version, per Robert: t and #t are completely different symbols. (The earlier draft did an order swap; Robert is right that the constant and the name should never be muddiable at all — this version removes the muddle by construction.)
The bug: my #89 fix represented the truth constant as the SYMBOL t, so the self-eval check shadowed every function parameter named t. super.lisp's q-term/loan-charge/bid-for take a t param — loan-charge computed NaN, the cap check failed, and super never bid a loan in any preset. Its 59-win canonical baseline was deposits/bonds/auctions only. mill.lisp has the same class.
The fix:
#tis now its own value kind (true, String() prints#t), self-evaluating and truthy — no relationship to the symbol t.tis a plain symbol: bindable, shadowable, a normal loud error when unbound. The #89 reservedNames entry for t is removed.tsymbol as an else keyword (else iselse;#tworks as a test via truthiness).Tests: t params receive arguments (exp4's repro plus multi-arg/defun/q-term shapes); t is definable and shadowable; #t stays truthy as a test and as a value;
#tand a numerictcoexist in one expression; unbound symbols still error.Verified: go build, full test suite, go vet, spectate smoke with the canonical super.lisp (seed 33) → 0 ai errors / 0 divergence.
After merge: the #97 team re-baselines — super's true number with live loan bidding is unknown and will move.
tself-evaluates BEFORE env lookup —tparams receive #t (super/mill loan hooks return NaN, super never bids loans) #98tself-evaluates BEFORE env lookup —tparams receive #t (super/mill loan hooks return NaN, super never bids loans) #98