Rework player bank info display #113
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently bank info is really inconsistent and this is very annoying for a human player.
This is the base bank info display
it's ugly, clean it up.
One big issue is none of these numbers are in context, so I want to see what they were at the start of last turn instead of having to scroll up.
it should include our deposit rate, reserve requirement, effective loan rate, effective loan term, number of outstanding loans, effective bond rate, effective bond term, number of outstanding bonds.
the new display should be printed everywhere before you make a decision.
Other notes:
in the same way that you have
for loans, you should have a similar display for bonds.
You display the turn header and the deposit table twice each turn.
first
second
And for some reason you have defaults only displayed on the second one, which is really incorrect, these should be displayed as soon as the turn starts and the dice is rolled.
the loan info line is too long, remove examples(same with bond line)
Taking #113 in full: clean bank info display with last-turn-start context on every number, the extra fields (deposit rate, reserve requirement, effective loan rate/term/count, effective bond rate/term/count), the bond display parallel to the loan award summary, the duplicated turn header and deposit table deduped, defaults shown at the turn start right after the die, and the over-long loan/bond help lines trimmed. Branch off master, gate, scripted smoke, headless regression, PR with progress comments.
@Winnie what happened?
Nothing went wrong — I'm on it. Status:
#88 is done and up for your review as PR #114 (branch 88-failure-calc): the shore-up math now lives in exactly one place (Game.shoreUpNeed) shared by the take screen and the finance phase, and the equity requirement is removed from the bankruptcy pass — a bank fails only on negative cash after bills or an unreserved position the market can't shore. The tight-cash repro that used to wipe the table now runs 16 turns and ends with a winner.
#113 is in progress on branch 113-player-display. I've mapped all eight items and I'm mid-implementation: the double display is fixed structurally (the turn-end log flush is gone for interactive games, every line now streams live exactly once, which also puts the defaults right after the die where you asked), and I'm building the new HUD — clean layout, last-turn-start context on every number, and the added fields: deposit rate, reserve requirement, effective loan rate/term/count, effective bond rate/term/count. Then the bond summary parallel to the loan one and the help-line trims. Build, gate, scripted smoke, headless regression, PR.
I'll post on the issue as each piece lands.
Done and up for review as PR #115 (branch 113-player-display, requested review). All eight items from the issue:
Verified with a scripted interactive smoke (one header and one deposit table per turn, was-values present, bond summary present) and a headless spectate regression (zero divergences, zero AI errors, no HUD leakage).