#124 - MAJOR: revokeOffers returns committed cash without booking CF.BondsReturned — CF DIVERGENCE on every revocation turn - Winnie/bankwars

Winnie commented

2026-10-01 15:31:08 +00:00

Owner

Found by the v0.6.0 review (issue #118). revokeOffers (game.go:458-468) does b.Cash += o.Price*o.Size but never records CF.BondsReturned. The finance-phase reconciliation (game.go:833-837) then computes a cash-flow statement that misses the return, logs "CF DIVERGENCE", and misstates the GAAP report every turn a bank revokes. Both sibling paths book it correctly: offer expiry (game.go:766-767) and own-offer retirement (game.go:553).

Verified end-to-end: place 900×10, revoke → "CF DIVERGENCE Bank 1 turn 1: cf -9000 actual 0". Dormant under defaults (Revocation=false, shipped brains return #f from revoke?) but it is a first-class config feature and reachable via the (revoke-offers) builtin regardless of the flag.

Found by the v0.6.0 review (issue #118). revokeOffers (game.go:458-468) does b.Cash += o.Price*o.Size but never records CF.BondsReturned. The finance-phase reconciliation (game.go:833-837) then computes a cash-flow statement that misses the return, logs "CF DIVERGENCE", and misstates the GAAP report every turn a bank revokes. Both sibling paths book it correctly: offer expiry (game.go:766-767) and own-offer retirement (game.go:553). Verified end-to-end: place 900×10, revoke → "CF DIVERGENCE Bank 1 turn 1: cf -9000 actual 0". Dormant under defaults (Revocation=false, shipped brains return #f from revoke?) but it is a first-class config feature and reachable via the (revoke-offers) builtin regardless of the flag.

Winnie referenced this issue

2026-10-01 15:31:23 +00:00

Massive code review before v0.6.0 #118

Winnie was assigned by robertismo

2026-10-01 15:43:04 +00:00

Winnie referenced this issue from a commit

2026-10-01 15:47:28 +00:00

revokeOffers books CF.BondsReturned — cash-flow statement reconciles (Closes #124)

Winnie referenced this issue from a pull request that will close it,

2026-10-01 15:47:36 +00:00

revokeOffers books CF.BondsReturned — cash-flow statement reconciles (Closes #124) #133