[#80 finding] NaN AI bids propagate through auctions and cash (no engine guard)

Winnie commented

2026-09-30 01:16:26 +00:00

Owner

An AI bid (or deposit rate) that computes to NaN passes straight through the engine: clampf(NaN) = NaN, the auction sort then produces arbitrary winners, the winner's cash -= NaN poisons its books, and equity prints "NaN" in the bench table (super showed "avg equity NaN, maxAbs +Inf" on the 100-game run; repro: base seed 79194, all-super roster, turn 14 auction).

Two layers:

Engine: clampf (and the auction sort) should reject/normalize NaN and +Inf from AI inputs — a single bad brain must not be able to poison a game. Suggest clampf returning 0 for NaN/Inf, and a log line.
Brain: the pow((1 − κ×hazard), term) in an auction haircut goes NaN when the base turns negative (κ×hazard > 1 from calibration compounding). The fix on the brain side is a max(0, base) guard; the engine-side guard makes this class of bug loud instead of silent.

Found during the reviewer-1 100-game bench (issue #80 work).

An AI bid (or deposit rate) that computes to NaN passes straight through the engine: clampf(NaN) = NaN, the auction sort then produces arbitrary winners, the winner's cash -= NaN poisons its books, and equity prints "NaN" in the bench table (super showed "avg equity NaN, maxAbs +Inf" on the 100-game run; repro: base seed 79194, all-super roster, turn 14 auction). Two layers: 1. Engine: clampf (and the auction sort) should reject/normalize NaN and +Inf from AI inputs — a single bad brain must not be able to poison a game. Suggest clampf returning 0 for NaN/Inf, and a log line. 2. Brain: the pow((1 − κ×hazard), term) in an auction haircut goes NaN when the base turns negative (κ×hazard > 1 from calibration compounding). The fix on the brain side is a max(0, base) guard; the engine-side guard makes this class of bug loud instead of silent. Found during the reviewer-1 100-game bench (issue #80 work).

robertismo commented

2026-09-30 01:23:49 +00:00

if an AI produces NaN, reject the value and fail the bank, putting it up for auction when appropriate. @Winnie

Winnie was assigned by robertismo

2026-09-30 01:24:00 +00:00

Winnie referenced this issue from a commit

2026-09-30 01:30:58 +00:00

[#91] Reject non-finite AI values and fail the bank: every AI entry point (6 action builtins + 5 hook returns) sanitizes NaN/Inf, the fault is logged loudly, and the bank goes to auction in financePhase. Regression tests for deposit-rate, bankruptcy-bid, loan-bids NaN paths + finite-books invariant.

~~Winnie referenced this issue 2026-09-30 01:31:08 +00:00~~

[#91] Reject non-finite AI values and fail the bank (Closes #91) #92

Winnie commented

2026-09-30 01:31:23 +00:00

Author

Owner

Implemented per your ruling. PR #92 (branch 91-nan @ d4e4059), review requested.

Every AI value entry point now rejects NaN/±Inf: the six action builtins (set-deposit-rate, bid-loans, bid-loan, offer-bond, take-bonds, bid-acquisition) and all five hook returns (deposit-rate, loan-bids, bond-offers, bond-take, bankruptcy-bid). A rejected value is zeroed/skipped, the fault is logged to the game log AND stderr (loud in headless benches), and the bank is failed and put up for auction in financePhase's bankruptcy pass — the same path unreserved positions take, so the auction still runs normally. Auction prices can no longer be NaN.

Verified: full test suite (5 new regression tests: NaN deposit rate, NaN auction bid, NaN loan bid, the original NaN-at-auction repro shape, finiteAI classification), go vet, spectate smoke seed 33 → 0 ai errors / 0 divergence / 0 non-finite.

The brain-side root cause (a pow base going negative in the auction haircut) is being fixed separately on the #80 branch; this PR makes the whole class loud instead of silent no matter which brain produces it.

Implemented per your ruling. **PR #92** (branch 91-nan @ d4e4059), review requested. Every AI value entry point now rejects NaN/±Inf: the six action builtins (set-deposit-rate, bid-loans, bid-loan, offer-bond, take-bonds, bid-acquisition) and all five hook returns (deposit-rate, loan-bids, bond-offers, bond-take, bankruptcy-bid). A rejected value is zeroed/skipped, the fault is logged to the game log AND stderr (loud in headless benches), and the bank is failed and put up for auction in financePhase's bankruptcy pass — the same path unreserved positions take, so the auction still runs normally. Auction prices can no longer be NaN. Verified: full test suite (5 new regression tests: NaN deposit rate, NaN auction bid, NaN loan bid, the original NaN-at-auction repro shape, finiteAI classification), go vet, spectate smoke seed 33 → 0 ai errors / 0 divergence / 0 non-finite. The brain-side root cause (a pow base going negative in the auction haircut) is being fixed separately on the #80 branch; this PR makes the whole class loud instead of silent no matter which brain produces it.

Winnie referenced this issue from a pull request that will close it,

2026-09-30 01:35:41 +00:00

[#91] Reject non-finite AI values and fail the bank (Closes #91) #92

robertismo closed this issue

2026-09-30 01:35:46 +00:00

robertismo referenced this issue from a commit

2026-09-30 01:35:47 +00:00

Merge pull request '[#91] Reject non-finite AI values and fail the bank (Closes #91)' (#92) from 91-nan into master

Winnie referenced this issue

2026-09-30 01:37:01 +00:00

v0.5.0: the super AI — state machine, 85%+ wins in all scenarios, validated #80

~~Winnie referenced this issue 2026-09-30 01:52:43 +00:00~~