bid-loans/bid-loan builtins clamp to ±cap like every other path (Closes #126) #135

Merged

robertismo merged 2 commits from 126-negbuiltin into master 2026-10-01 15:52:09 +00:00

Conversation 0 Commits 2 Files changed 1 +2 -2

Winnie commented 2026-10-01 15:51:40 +00:00

Owner

Copy link

The two action builtins clamped loan bids to [0, cap] while the hook-return path, the engine, and the wizard's documented contract all use ±cap — brains using the action API could never submit the negative undercut bids the v0.5.0 negative-rates feature exists for. Both builtins now clamp to ±cap.

Verified: a brain bidding (bid-loans -0.05) books loans at −5.00% and wins them, where it previously clamped to 0. Full suite + vet clean.

The two action builtins clamped loan bids to [0, cap] while the hook-return path, the engine, and the wizard's documented contract all use ±cap — brains using the action API could never submit the negative undercut bids the v0.5.0 negative-rates feature exists for. Both builtins now clamp to ±cap. Verified: a brain bidding (bid-loans -0.05) books loans at −5.00% and wins them, where it previously clamped to 0. Full suite + vet clean.

Winnie added 1 commit 2026-10-01 15:51:40 +00:00

bid-loans/bid-loan builtins clamp to +-cap like every other path (Closes #126) ... 36e0543101

The two action builtins clamped loan bids to [0, cap] while the
hook-return path, the engine, and the wizard's documented contract all
use +-cap, so brains using the action API could never submit the
negative undercut bids the v0.5.0 negative-rates feature exists for
(the human per-loan path was already widened in #120). Both builtins
now clamp to +-cap.

Verified: a brain bidding (bid-loans -0.05) books loans at -5.00% and
wins them, where it previously clamped to 0.

robertismo added 1 commit 2026-10-01 15:52:03 +00:00

Merge branch 'master' into 126-negbuiltin a9341a7a00

robertismo merged commit 686a2f5584 into master 2026-10-01 15:52:09 +00:00

robertismo referenced this pull request from a commit 2026-10-01 15:52:10 +00:00

Merge pull request 'bid-loans/bid-loan builtins clamp to ±cap like every other path (Closes #126)' (#135) from 126-negbuiltin into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Winnie/bankwars!135

No description provided.