Winnie/bankwars
Watch
1
0
Fork
You've already forked bankwars
 0
Code Issues 9 Pull requests 2 Projects Releases 6 Packages Wiki Activity Actions

[#37] Remaining four two-mechanism hybrid specialists #44

Merged
robertismo merged 1 commit from 37-hybrids into master 2026-09-29 18:16:56 +00:00
Conversation 3 Commits 1 Files changed 5 +148 -3
Winnie commented 2026-09-29 18:15:16 +00:00
Owner
Copy link

Adds bond-auction-spec, deposit-bond-spec, loan-auction-spec, deposit-auction-spec, completing all six pairs. Each plays exactly its two mechanisms; thresholds are config-derived; smoke-tested via spectate games with no AI errors. Gauntlet wiring: all four appended to the specs list in runGauntlet.

Adds bond-auction-spec, deposit-bond-spec, loan-auction-spec, deposit-auction-spec, completing all six pairs. Each plays exactly its two mechanisms; thresholds are config-derived; smoke-tested via spectate games with no AI errors. Gauntlet wiring: all four appended to the specs list in runGauntlet.
Completes all six pairs of two-mechanism probes for issue #37. Each brain
plays exactly its two mechanisms (bond market both ways + auctions,
deposit funding + bond market, loan bidding + auctions, deposit funding +
auctions) and ignores the rest. All thresholds config-derived (dice-faces,
bond-face, bond-term, loan-min/max, rate caps); no hard-coded values.
Gauntlet wiring: all four appended to the specs list in runGauntlet.
Smoke-tested via spectate games with zero AI errors.
robertismo commented 2026-09-29 18:16:13 +00:00
First-time contributor
Copy link

weren't there six of these @Winnie ?

weren't there six of these @Winnie ?
Winnie commented 2026-09-29 18:16:25 +00:00
Author
Owner
Copy link

Yes, all six exist. The PR adds the four missing ones; the first two were already on master from the earlier iteration:

Already in the repo: deposit-loan-spec (deposit+loan), loan-bond-spec (loan+bond).
This PR adds: bond-auction-spec, deposit-bond-spec, loan-auction-spec, deposit-auction-spec.

That covers every pair of the four mechanisms: deposit+loan, deposit+bond, deposit+auction, loan+bond, loan+auction, bond+auction. After merge the gauntlet benches all six against the mains.

Yes, all six exist. The PR adds the four missing ones; the first two were already on master from the earlier iteration: Already in the repo: deposit-loan-spec (deposit+loan), loan-bond-spec (loan+bond). This PR adds: bond-auction-spec, deposit-bond-spec, loan-auction-spec, deposit-auction-spec. That covers every pair of the four mechanisms: deposit+loan, deposit+bond, deposit+auction, loan+bond, loan+auction, bond+auction. After merge the gauntlet benches all six against the mains.
Winnie commented 2026-09-29 18:17:02 +00:00
Author
Owner
Copy link

Note from smoke testing: one game with deposit-bond-spec surfaced an engine accounting divergence on the acquisition path (acquirer inherits the failed bank's standing bond offers). Mains-only smoke is clean, so it's the engine's offer-handover bookkeeping, not the brain. Filed as #45 with the evidence. This does not block the merge - the probe brains are correct; the engine path needs its own fix + unit test.

Note from smoke testing: one game with deposit-bond-spec surfaced an engine accounting divergence on the acquisition path (acquirer inherits the failed bank's standing bond offers). Mains-only smoke is clean, so it's the engine's offer-handover bookkeeping, not the brain. Filed as #45 with the evidence. This does not block the merge - the probe brains are correct; the engine path needs its own fix + unit test.
Sign in to join this conversation.
Reviewers
No reviewers
robertismo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Winnie/bankwars!44
No description provided.